Re: why does enum_endpoint call GetTransactionSnapshot()?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: why does enum_endpoint call GetTransactionSnapshot()?
Date: 2015-02-14 22:29:43
Message-ID: CA+TgmoZL8CX4Sy++SnhLKnV2t5_kDv3U3s=UzpOpckyMNg9L9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I think this is probably a holdover from before the death of
>> SnapshotNow, and that we should just pass NULL to
>> systable_beginscan_ordered() here, the same as we do for other catalog
>> accesses. Barring objections, I'll go make that change.
>
> Seems reasonable to me, but why are you only looking at that one and
> not the identical code in enum_range_internal()?

I noticed that one after hitting send. I think we should change them both.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-02-14 23:28:38 Re: restrict global access to be readonly
Previous Message Tom Lane 2015-02-14 22:12:42 Re: why does enum_endpoint call GetTransactionSnapshot()?