| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Declarative partitioning - another take |
| Date: | 2016-12-20 14:17:14 |
| Message-ID: | CA+TgmoZEwed3zp+CHOtekfHaf_880Njx2fq5nYUkOpL5D1GZ0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 20, 2016 at 4:51 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Amit Langote wrote:
>
>> diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
>> index 1c219b03dd..6a179596ce 100644
>> --- a/src/backend/commands/tablecmds.c
>> +++ b/src/backend/commands/tablecmds.c
>> @@ -13297,8 +13297,10 @@ ATExecAttachPartition(List **wqueue, Relation rel, PartitionCmd *cmd)
>> }
>> }
>>
>> + /* It's safe to skip the validation scan after all */
>> if (skip_validate)
>> - elog(NOTICE, "skipping scan to validate partition constraint");
>> + ereport(INFO,
>> + (errmsg("skipping scan to validate partition constraint")));
>
> Why not just remove the message altogether?
That's certainly an option. It might be noise in some situations. On
the other hand, it affects whether attaching the partition is O(1) or
O(n), so somebody might well want to know. Or maybe they might be
more likely to want a message in the reverse situation, telling them
that the partition constraint DOES need to be validated. I'm not sure
what the best user interface is here; thoughts welcome.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-12-20 14:23:37 | Re: Hash Indexes |
| Previous Message | Robert Haas | 2016-12-20 14:14:38 | Re: Hash Indexes |