Re: Do we need use more meaningful variables to replace 0 in catalog head files?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Jan de Visser <jan(at)de-visser(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Hao Lee <mixtrue(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Do we need use more meaningful variables to replace 0 in catalog head files?
Date: 2016-11-15 16:50:30
Message-ID: CA+TgmoZAkhyx5Og5Bht2JCVwfZV0HmyGjz_e3JFL+2YrZm0icg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 13, 2016 at 9:48 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I'm not convinced the line prefix part is necessary, though. What I'm
> thinking of is something like this:
>
> PROCDATA( oid=1242 name=boolin isstrict=t volatile=i parallel=s nargs=1
> rettype=bool argtypes="cstring" src=boolin );

I liked Tom's format a lot better. If we put this in a separate file
rather than in the header, which I favor, the PROCDATA stuff is just
noise. On the other hand, having the name as the first thing on the
line seems *excellent* for readability.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-11-15 16:58:18 Re: Patch: Implement failover on libpq connect level.
Previous Message Pavel Stehule 2016-11-15 16:48:22 Re: proposal: psql \setfileref