| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Implement failover on libpq connect level. |
| Date: | 2015-11-03 15:24:52 |
| Message-ID: | CA+TgmoZ7Qa1b4Do8cobiSV0y=_5Nwc5MhSYu-b6Wz1d8=TzPrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-jdbc |
On Mon, Nov 2, 2015 at 12:15 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 10/30/15 9:26 AM, Robert Haas wrote:
>> That's true, but doesn't allowing every parameter to be multiply
>> specified greatly increase the implementation complexity for a pretty
>> marginal benefit?
>
> Well, the way I would have approached is that after all the parsing you
> end up with a list of PQconninfoOption arrays and you you loop over that
> list and call connectDBStart() until you have a connection that
> satisfies you.
>
> I see that the patch doesn't do that and it looks quite messy as a result.
Hmm, I see. That approach certainly seems worth considering.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-11-03 15:26:21 | Re: Freeze avoidance of very large table. |
| Previous Message | Robert Haas | 2015-11-03 15:23:35 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | stallapp | 2015-11-03 15:34:56 | Re: Problem in getting column names from DatabaseMetadata Object |
| Previous Message | Vladimir Sitnikov | 2015-11-03 14:03:57 | Re: version 1205 |