| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: preserving forensic information when we freeze |
| Date: | 2013-12-19 02:42:25 |
| Message-ID: | CA+TgmoYq0GgRPGxiv9MONcmVipQeAMpd-WvnEf4F05gBhnx=Zw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 18, 2013 at 5:54 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> if (frz->frzflags & XLH_FREEZE_XVAC)
>> + {
>> HeapTupleHeaderSetXvac(tuple, FrozenTransactionId);
>> + /* If we somehow haven't hinted the tuple previously, do it now. */
>> + HeapTupleHeaderSetXminCommitted(tuple);
>> + }
>
> What's the reasoning behind adding HeapTupleHeaderSetXminCommitted()
> here?
I'm just copying the existing logic. See the final stanza of
heap_prepare_freeze_tuple.
> [ snip ]
Will fix.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2013-12-19 03:08:41 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters |
| Previous Message | Peter Eisentraut | 2013-12-19 02:11:40 | pgsql: Upgrade to Autoconf 2.69 |