Re: [PATCH] Log crashed backend's query (activity string)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Log crashed backend's query (activity string)
Date: 2011-09-24 19:23:12
Message-ID: CA+TgmoYg-7w15KpvkzgjJGj6Wjuuf9uimZonKH3yBs1bN9Seug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 24, 2011 at 1:51 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> It seems like everyone agrees that this feature is wanted, but Tom is
> still very much opposed to the general approach to implement it, as
> being too dangerous.
> Is it the reviewer's job to try to convince him otherwise?

It's not the reviewer's job to convince Tom of anything in particular,
but I think it's helpful for them to state their opinion, whatever it
may be (agreeing with Tom, disagreeing with Tom, or whatever).

IMHO, the most compelling argument against the OP's approach made so
far is the encoding issue. I was hoping someone (maybe the OP?) would
have an opinion on that, an idea how to work around it, or something.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-09-24 19:24:49 Re: [pgsql-advocacy] Unlogged vs. In-Memory
Previous Message Dimitri Fontaine 2011-09-24 19:15:25 Re: Satisfy extension dependency by one of multiple extensions