| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Subject: | Re: Foreign join pushdown vs EvalPlanQual |
| Date: | 2015-11-17 18:39:03 |
| Message-ID: | CA+TgmoYZeje+ot1kX4wdoB7R7DPS0CWXAzfqZ-14yKfkgKREAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 8, 2015 at 7:26 PM, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
> The attached patch is an adjusted version of the previous one.
> Even though it co-exists a new callback and fdw_recheck_quals,
> the callback is kicked first as follows.
This seems excessive to me: why would we need an arbitrary-length list
of plans for an FDW? I think we should just allow an outer child and
an inner child, which is probably one more than we'll ever need in
practice.
This looks like an independent bug fix:
+ fscan->fdw_recheck_quals = (List *)
+ fix_upper_expr(root,
+ (Node *)
fscan->fdw_recheck_quals,
+ itlist,
+ INDEX_VAR,
+ rtoffset);
pfree(itlist);
If so, it should be committed separately and back-patched to 9.5.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-11-17 18:50:36 | Re: Question concerning XTM (eXtensible Transaction Manager API) |
| Previous Message | andres@anarazel.de | 2015-11-17 18:36:13 | Re: [PATCH] Refactoring of LWLock tranches |