Re: 64-bit queryId?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Greg Stark <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 64-bit queryId?
Date: 2017-10-04 01:37:15
Message-ID: CA+TgmoYYXX=7WiMyzExTxHDUwVJeU9ByN_wRUa8jMrc6Cbjb-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 3, 2017 at 9:34 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> +/* Write an unsigned integer field (anything written with UINT64_FORMAT) */
> +#define WRITE_UINT64_FIELD(fldname) \
> + appendStringInfo(str, " :" CppAsString(fldname) " " UINT64_FORMAT, \
> + node->fldname)
> Correct call here.

I'm sorry, but I don't understand this comment.

> {
> - return hash_any((const unsigned char *) str, len);
> + return hash_any_extended((const unsigned char *) str, len, 0);
> }
> [...]
> - uint32 start_hash = hash_any(jumble, JUMBLE_SIZE);
> + uint64 start_hash = hash_any_extended(jumble, JUMBLE_SIZE, 0);
> Missing two DatumGetUInt64() perhaps? HEAD looks wrong to me as well.

Ah, yes, you're right.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-10-04 01:38:56 Re: [BUGS] BUG #14825: enum type: unsafe use?
Previous Message Badrul Chowdhury 2017-10-04 01:35:06 Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)