| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
| Cc: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Subject: | Re: Speedup twophase transactions |
| Date: | 2017-01-31 17:25:47 |
| Message-ID: | CA+TgmoYXFszejwyMDOVEcvVTKvzQG7HvrHmzOA6cdmPDT7Z7Kg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 23, 2017 at 7:00 AM, Nikhil Sontakke
<nikhils(at)2ndquadrant(dot)com> wrote:
> 4) Minor nit-pick on existing code.
>
> (errmsg_plural("%u two-phase state file was written "
> "for
> long-running prepared transactions",
> "%u
> two-phase state files were written "
> "for
> long-running prepared transactions",
> serialized_xacts,
> serialized_xacts)
>
> Shouldn’t the singular part of the message above be:
> "%u two-phase state file was written for a long-running prepared transaction"
>
> But, then, English is not my native language, so I might be off here :-)
If there's one file per long-running prepared transaction, which I
think is true, then I agree with you.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2017-01-31 18:06:39 | Re: Floating point comparison inconsistencies of the geometric types |
| Previous Message | Corey Huinker | 2017-01-31 17:24:31 | Re: COPY as a set returning function |