| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andreas Seltenreich <seltenreich(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Failed assertions on parallel worker shutdown |
| Date: | 2016-06-06 18:50:03 |
| Message-ID: | CA+TgmoYTA_jDbiHQWFXnSTPs+MQSYwv76zeYCx7c0-UBAH2_oA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 4, 2016 at 2:57 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> In the above change, you are first adding bytes_written and then doing the
> SHM_MQ_DETACHED check, whereas other place the check is done first which
> seems to be right. I think it doesn't matter either way, but it is better
> to be consistent. Also isn't it better to set mqh_length_word_complete as
> false as next time this API is called, it should first try to write length
> into buffer.
OK, committed after (I hope) fixing those issues.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-06 18:53:41 | Re: Changed SRF in targetlist handling |
| Previous Message | David G. Johnston | 2016-06-06 18:48:27 | Re: Changed SRF in targetlist handling |