| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44) |
| Date: | 2015-03-09 14:36:28 |
| Message-ID: | CA+TgmoYSWhwq3RXbmPA0a6cMMHZ=9-EN5mMH6TSkxx0QH3gt6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 4, 2015 at 1:55 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Wed, Mar 4, 2015 at 8:26 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I think we should commit my patch, and if a future patch needs
>> sortKeys set in more places, it can make that change itself. There's
>> no reason why it's needed with the code as it is today, and no reason
>> to let bits of future changes leak into a bug-fix patch.
>
> It's not as if I feel strongly about it. It's trivial to change the
> code to make the comment true, rather than change the comment to make
> the code true, and we need to do so anyway. I defer to you.
I did it my way. Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2015-03-09 14:38:59 | Re: Parallel Seq Scan |
| Previous Message | Andrew Dunstan | 2015-03-09 14:33:20 | Re: Object files generated by ecpg test suite not ignored on Windows |