| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | incorrect libpq comment |
| Date: | 2016-10-19 17:16:28 |
| Message-ID: | CA+TgmoYBygEYgp0=X7y6ewZ8hj+tHmtYNf2FB1WAyi1wjg1-9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce's commit 5d305d86bd917723f09ab4f15c075d90586a210a back in April
of 2014 includes this change:
/* See PQconnectPoll() for how we use 'int' and not 'pgsocket'. */
- int sock; /* Unix FD for socket, -1 if not connected */
+ pgsocket sock; /* FD for socket, PGINVALID_SOCKET if
unconnected */
I suppose Bruce must have overlooked the fact that the comment on the
previous line is now false. I think we should remove it, because it
makes no sense to say how we are using 'int' rather than 'pgsocket'
when in fact we are not using 'int' any more.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-10-19 17:25:33 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |
| Previous Message | Bruce Momjian | 2016-10-19 17:11:09 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |