From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: shm_mq fix for non-blocking mode |
Date: | 2015-10-23 02:00:57 |
Message-ID: | CA+TgmoYBrpX4CL=0XpUDiKaVyJf1nx+zGaNpxtfSqMCeYTVmSw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 22, 2015 at 4:45 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Oct 16, 2015 at 5:08 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> The shm_mq code handles blocking mode and non-blocking mode
>> asymmetrically in a couple of places, with the unfortunate result that
>> if you are using non-blocking mode, and your counterparty dies before
>> attaching the queue, operations on the queue continue to return
>> SHM_MQ_WOULD_BLOCK instead of, as they should, returning
>> SHM_MQ_DETACHED. The attached patch fixes the problem. Thanks to my
>> colleague Rushabh Lathia for helping track this down.
>>
>> (There's are some further bugs in this area outside the shm_mq code
>> ... but I'm still trying to figure out exactly what they are and what
>> we should do about them. This much, however, seems clear-cut.)
>
> ...and so I've committed it and back-patched to 9.4.
Sigh. This was buggy; I have no idea how it survived my earlier testing.
I will go fix it. Sorry.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-10-23 02:59:27 | Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::') |
Previous Message | Stephen Frost | 2015-10-23 01:35:15 | Re: Making tab-complete.c easier to maintain |