Re: Possible performance bug in enumerating schema objects?

On Wed, Nov 14, 2012 at 7:54 PM, Avi Blackmore <support(at)satshot(dot)com> wrote:
>
> On Nov 14, 2012, at 1:47 AM, Dave Page wrote:
>
>> On Tue, Nov 13, 2012 at 6:57 PM, Avi Blackmore <support(at)satshot(dot)com> wrote:
>>> Hi, just got back to the office. Thanks for the response!
>>>
>>> On Nov 8, 2012, at 10:25 AM, Dave Page wrote:
>>>
>>>>> Given the size of the pg_class result set, this strikes me as really, really inefficient. Perhaps these options could be queried in one go, by joining against the main query for the listing of tables and other objects?
>>>>
>>>> I've attached a patch that attempts to do exactly that. Are you able to test it?
>>>>
>>>
>>> I installed a binary image for my MacOS X workstation. I'd have to grab the source and build that. What's the version the patch applies against? Current release?
>>
>> I developed it against the master branch, but I suspect it'll apply to
>> the 1.16 branch too, as I don't think anything has changed in the
>> affected file in master only.
>
>
> I grabbed the source for 1.16, and applied the patch. It applied without problems. Built a new appbundle, and schema enumeration is now much much faster. Only a couple of seconds.
>
> I'd say the patch works! Thanks very much for your help.

Great, thanks for testing. I'll get it applied.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company