From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixing issues between objects and properties dialogs |
Date: | 2011-07-24 14:07:28 |
Message-ID: | CA+OCxoz0Tu9TVzvEWnsD=3RnPe5XuVQPX0d_PzzSnSumLc+9YA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Sun, Jul 24, 2011 at 1:11 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote:
>> The former fix seems more appropriate. Operations in frmMain shouldn't
>> cause dialogues to close.
>>
>
> Fine with me. That should be simpler to do.
>
>> Simple fix seems to be to store a pointer to the dialog in pgObject;
>> if not null, disallow drop, or if trying to view properties, use the
>> pointer to raise the existing dialogue. Clear the pointer when the
>> dialog is closed.
>>
>
> I thought of something similar, but this is OK with me.
>
> I expect it to be quite a big patch. Should I work on 1.14 or master?
> this is surely a bug, so 1.14 should be OK. But I'm afraid this is too
> much changes to code it on a beta release. Any strong opinion on this
> matter?
Seems like something for 1.15 to me.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2011-07-24 14:09:06 | Re: Fixing issues between objects and properties dialogs |
Previous Message | Vladimir Kokovic | 2011-07-24 14:00:51 | Re: Copy/Paste table(s) functions - git context patch |