| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Failed assertion in postgres_fdw/deparse.c:1116 |
| Date: | 2016-06-07 12:49:23 |
| Message-ID: | CA+HiwqEtJagGCuYSLkN+Oi+GhuNYqFDNwcRiD+7jaggH1=9DLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 7, 2016 at 7:47 PM, Ashutosh Bapat wrote:
> On Tue, Jun 7, 2016 at 4:07 PM, Amit Langote wrote:
>> On 2016/06/07 19:13, Ashutosh Bapat wrote:
>> > So, your patch looks to be the correct approach (even after we support
>> > deparsing subqueries). Can you please include a test in regression?
>>
>> I added a slightly modified version of your test to the originally posted
>> patch.
>>
> Looks good to me. If we add a column from the outer relation, the "NULL"ness
> of inner column would be more clear. May be we should tweak the query to
> produce few more rows, some with non-NULL columns from both the relations.
> Also add a note to the comment in the test mentioning that such a join won't
> be pushed down for a reader to understand the EXPLAIN output. Also, you
> might want to move that test, closer to other un-pushability tests.
Done in the attached. Please check if my comment explains the reason
of push-down failure correctly.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| pgfdw-join-pd-bug-3.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-07 13:26:11 | Re: slower connect from hostnossl clients |
| Previous Message | Stephen Frost | 2016-06-07 12:48:32 | Re: Problem with dumping bloom extension |