Re: Patch: initdb: "'" for QUOTE_PATH (non-windows)

On August 17, 2016 8:15:56 PM PDT, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:

>+ { /* pg_ctl command w path, properly quoted */
>+ PQExpBuffer pg_ctl_path = createPQExpBuffer();
>+ printfPQExpBuffer(pg_ctl_path, "%s%spg_ctl",
>+ bin_dir,
>+ (strlen(bin_dir) > 0) ? DIR_SEP : ""
>+ );
>+ appendShellString(start_db_cmd, pg_ctl_path->data);
>+ destroyPQExpBuffer(pg_ctl_path);
>+ }
>
>This is not really project-style to have an independent block. Usually
>those are controlled by for, while or if.

Besides the comment positioning I'd not say that that is against the usual style, there's a number of such blocks already. Don't think it's necessarily needed here though...
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.