Re: Libpq COPY optimization patch

From: "Alon Goldshuv" <agoldshuv(at)greenplum(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Libpq COPY optimization patch
Date: 2006-01-24 16:40:06
Message-ID: BFFC2506.C22A%agoldshuv@greenplum.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> You mean something like
>
> if (input-buffer-not-empty)
> parseInput();
>
> ? This still bothers me a bit since it's a mixing of logic levels;
> PQputCopyData is an output routine, it shouldn't be getting its fingers
> dirty with input buffer contents. I'm willing to tolerate this if it
> can be demonstrated that it provides a useful performance gain compared
> to the unconditional parseInput call, but let's see some numbers.

Yes, I understand. We'll see what the performance gain is like and see if
it's worth it, I'll report back.

Alon.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2006-01-24 21:49:08 Re: [PATCHES] postmaster/postgres merge for testing
Previous Message Tom Lane 2006-01-24 15:36:35 Re: Libpq COPY optimization patch