From: | "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: this patch correct upper and lower case for translated month's and |
Date: | 2006-11-29 23:32:26 |
Message-ID: | BAY20-F2309823DCC4193DB751A52F9E40@phx.gbl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
>
>"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> > this patch correct bug in to_char function with incorrect uppercased
>month's
> > or day's name.
>
>I still think this coding is unsafe in the case where the modified
>string is longer than the original. Also, could we please not duplicate
>such a large chunk of code between here and oracle_compat.c?
>
> regards, tom lane
I hope so not. It's safe if argument "inout" is pointer on safety long
buffer. Propably this function's can sit in somewhere else, but I expect so
will for text and str, because without controls has only 2 lines of code.
This patch is minimalistic, without others non neccesery changes.
Regards
Pavel Stehule
_________________________________________________________________
Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci.
http://messenger.msn.cz/
From | Date | Subject | |
---|---|---|---|
Next Message | soni de | 2006-11-30 03:17:34 | Re: Regarding PQputline and PQendcopy |
Previous Message | Tom Lane | 2006-11-29 23:13:54 | Re: this patch correct upper and lower case for translated month's and day's names |
From | Date | Subject | |
---|---|---|---|
Next Message | Hiroshi Saito | 2006-11-30 01:29:23 | win32.mak patch of pg_dump. |
Previous Message | Tom Lane | 2006-11-29 23:13:54 | Re: this patch correct upper and lower case for translated month's and day's names |