Re: Fill factor cannot be modified

From: Thom Brown <thom(at)linux(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: Fill factor cannot be modified
Date: 2011-06-20 13:42:14
Message-ID: BANLkTinwfSBGf-wRDNtTj_1HnRUBRLF3dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

On 20 June 2011 11:00, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Fri, Jun 17, 2011 at 6:39 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>> On 17 June 2011 18:18, Thom Brown <thom(at)linux(dot)com> wrote:
>>> On 17 June 2011 18:16, Thom Brown <thom(at)linux(dot)com> wrote:
>>>
>>>> Very well then.  Dodgy patch attached.
>>>
>>> And again without ugly whitespace.
>>
>> Erk... just been trying to break it and found that this generates the
>> alter statement every time once the value has been set, so fixed that
>> too (attached).
>
> LOL. The patch looks great as far as it goes - not at all dodgy. It
> currently only affects tables though - you need to do roughly the same
> thing in dlgIndex.cpp and dlgIndexConstraint.cpp to cover the cases
> you reported :-)

Okay, updated patch attached. This enables modification of fill
factor on existing tables and primary keys.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
fix_fillfactor_v2.patch text/x-patch 3.3 KB

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2011-06-20 19:20:36 Re: Fill factor cannot be modified
Previous Message Dave Page 2011-06-20 10:00:59 Re: Fill factor cannot be modified