From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 |
Date: | 2011-04-28 19:33:44 |
Message-ID: | BANLkTin_oy7biEEzhn6LvfMhvKqpgEhtAQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 28, 2011 at 6:21 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Tom Lane's message of mié abr 27 17:10:37 -0300 2011:
>>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>>> Apparently this change is causing Moa's SunStudio compiler to fail an
>>>> assertion.
>
>>> [ scratches head... ] Hard to see why, there's nothing at all
>>> interesting in that code.
>
>> I agree, but it fails exactly in that code, and started to fail
>> immediately after that patch.
>
>> Maybe casting the 2 to int64 would fix it?
>
> I'm not excited about trying random code changes to dodge a compiler bug
> with a 24-hour turnaround time. Dave, can you poke at this?
I think we may have to award Sun (or whats left of them) the "Bizarre
compiler bug of the week" award here. It's actually the val++; that's
causing the assertion, but I'm darned if I can get it to work. I've
tried spelling out the addition, casting, changing val to an int64*,
renaming val, and probably a dozen or so things that are broken, all
with no success.
Any other ideas?
--
Dave Page
PostgreSQL Core Team
http://www.postgresql.org/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-04-28 19:44:26 | Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 |
Previous Message | Andrew Dunstan | 2011-04-28 19:07:52 | pgsql: Add some casts to try to silence most of the remaining format wa |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2011-04-28 19:41:12 | ALTER TYPE DROP + composite-typed col vs. pg_upgrade |
Previous Message | Michael Meskes | 2011-04-28 19:24:45 | Re: unknown conversion %m |