Re: Adding an example for replication configuration to pg_hba.conf

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Selena Deckelmann <selena(at)chesnok(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding an example for replication configuration to pg_hba.conf
Date: 2011-05-19 18:05:54
Message-ID: BANLkTin9aYQ51cuUnYxTLbbvZqKApYVEfg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 19, 2011 at 11:09, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Thu, May 19, 2011 at 2:44 PM, Selena Deckelmann <selena(at)chesnok(dot)com> wrote:
>> On Wed, May 18, 2011 at 8:20 PM, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> Excerpts from Greg Smith's message of mié may 18 23:07:13 -0400 2011:
>>>> Two things that could be changed from this example to make it more useful:
>>>
>>>> -The default database is based on your user name, which is postgres in
>>>> most packaged builds but not if you compile your own.  I don't know
>>>> whether it's practical to consider substituting that into this file, or
>>>> if it's just enough to mention that as an additional doc comment.
>>>
>>> You mean the default username, not the default database, but yeah; so do
>>> we need a @default_username@ token to be replaced by initdb with
>>> whatever it has as effective_user?  (In this case the patch is no longer
>>> 2 lines, but still should be trivial enough).
>>
>> That would be nice. So, we just add that token to initdb? Seems simple.
>>
>> I added some explanation of the all vs replication bit in the header comments.
>>
>> Revision attached.
>
> Looks good to me.
>
> As I mentioned offlist, I'd like it in teal please.

Applied with some further minor bikeshedding (remove trailing spaces,
rewrap so columns aren't wider than 80 chars, etc)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2011-05-19 18:12:24 Re: Patch by request at pgcon
Previous Message Alvaro Herrera 2011-05-19 17:56:20 Re: Patch by request at pgcon