Re: Error in PQsetvalue

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Pavel Golub <pavel(at)gf(dot)microolap(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Chernow <ac(at)esilo(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Pavel Golub <pavel(at)microolap(dot)com>
Subject: Re: Error in PQsetvalue
Date: 2011-06-09 20:40:08
Message-ID: BANLkTimhWUE5CbAWLxNnG85AoQUo7Okf1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 9, 2011 at 12:48 AM, Pavel Golub <pavel(at)microolap(dot)com> wrote:
>>> it's a feature addition I approve of.  I think serious consideration
>>> ought to be given to locking down returned results so PQsetvalue refuses
>>> to touch them, instead.  Otherwise we're likely to find ourselves unable
>>> to make future optimizations because we have to support this
>>> barely-used-by-anybody corner case.
>
> Do I understand correctly that there is no any chance at all to have function
> like PQdeleteTuple in libpq? (see my message "PQdeleteTuple
> function in libpq" on Wed, 1 Jun 2011)

It means the feature is on thin ice. I'm personally in favor of
keeping it, and perhaps cautiously exploring ways to go further. I'm
waiting for Tom to make a call...I see three options:

1) patch bug and leave behavior alone (apply andrew C's patch)
2) discuss behavior change in -hackers
3) patch bug and behavior immediately (get a new patch with doc change as well)

merlin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-06-09 20:41:03 Re: Postmaster holding unlinked files for pg_largeobject table
Previous Message Alvaro Herrera 2011-06-09 20:34:13 Re: Postmaster holding unlinked files for pg_largeobject table