Re: [PERFORM] Hash Anti Join performance degradation

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
Cc: panam <panam(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PERFORM] Hash Anti Join performance degradation
Date: 2011-06-01 00:55:38
Message-ID: BANLkTimRjbzjqA13MLtjLf1XCini_UAAQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

On Tue, May 31, 2011 at 8:43 PM, Cédric Villemain
<cedric(dot)villemain(dot)debian(at)gmail(dot)com> wrote:
> Yes, while here I noticed that the query was long to be killed.
> I added a CHECK_FOR_INTERRUPT() in the for(;;) loop in nodeHashjoin.c.
> It fixes the delay when trying to kill but I don't know about
> performance impact this can have in this place of the code.

Well, seems easy enough to find out: just test the query with and
without your patch (and without casserts). If there's no measurable
difference on this query, there probably won't be one anywhere.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-06-01 01:00:59 Re: creating CHECK constraints as NOT VALID
Previous Message Mark Kirkwood 2011-06-01 00:46:18 Re: patch review : Add ability to constrain backend temporary file space

Browse pgsql-performance by date

  From Date Subject
Next Message Cédric Villemain 2011-06-01 01:11:16 Re: [PERFORM] Hash Anti Join performance degradation
Previous Message Cédric Villemain 2011-06-01 00:43:05 Re: [PERFORM] Hash Anti Join performance degradation