Re: make check in contrib

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make check in contrib
Date: 2011-04-25 15:43:53
Message-ID: BANLkTim950GOKk_vosrjnho5x8NA1baHCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 25, 2011 at 11:22 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>>>> I noticed again that make check in contrib doesn't work, so here is a
>>>>> patch to fix it.
>
>>>> I think it might be more useful to have a check target that actually
>>>> succeeds, even if it does nothing useful.
>
>>> That argument seems a bit irrelevant to the proposed patch.
>
>> How so?
>
> The proposed patch is to fix it, not remove it.  Surely that's more
> useful than a no-op target.

Oh, that's different... never mind.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aidan Van Dyk 2011-04-25 15:49:40 Re: branching for 9.2devel
Previous Message Robert Haas 2011-04-25 15:41:19 Re: branching for 9.2devel