Re: Fill factor cannot be modified

From: Thom Brown <thom(at)linux(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: Fill factor cannot be modified
Date: 2011-06-17 17:18:20
Message-ID: BANLkTikRXWA8W98rK7xsFnnhYDyu_aqZAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

On 17 June 2011 18:16, Thom Brown <thom(at)linux(dot)com> wrote:
> On 16 June 2011 15:41, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Thu, Jun 16, 2011 at 2:45 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> Hi,
>>>
>>> I'm using PgAdmin III 1.14.0 beta 1 and noticed that if I go into the
>>> properties dialog box for a table, the Fill Factor field cannot be
>>> modified.  I've manually altered a table so that the fill factor is
>>> set to a valid value, re-checked the properties box and can see my new
>>> value in the Fill Factor field.  However, it still cannot be modified.
>>
>> This appears to be a missing feature. We need to add code to support
>> adjustment of the fill factor on existing tables.
>>
>>> Also, the properties dialog box for a primary key also has a Fill
>>> Factor field, and values can be entered into it, but the OK button
>>> stays greyed out and the SQL tab shows nothing to be changed.
>>
>> That has the same issue, plus a bug which leaves the field enabled.
>> I'll push a fix for the bug - a patch would be cool for the new
>> feature though :-p
>
> Very well then.  Dodgy patch attached.

And again without ugly whitespace.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
fix_fillfactor.patch text/x-patch 1.5 KB

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Thom Brown 2011-06-17 17:39:48 Re: Fill factor cannot be modified
Previous Message Thom Brown 2011-06-17 17:16:29 Re: Fill factor cannot be modified