Re: Alignment padding bytes in arrays vs the planner

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Alignment padding bytes in arrays vs the planner
Date: 2011-05-24 18:21:02
Message-ID: BANLkTi=y_K0BmpvnYgiBkyGMEp0HhhBorA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 24, 2011 at 2:18 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Tue, May 24, 2011 at 2:11 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>>> QTN2QT() allocates memory for a TSQuery using palloc().  TSQuery contains an
>>> array of QueryItem, which contains three bytes of padding between its first and
>>> second members.  Those bytes don't get initialized, so we have unpredictable
>>> content in the resulting datum.
>
>> OK, so I guess this needs to be applied and back-patched to 8.3, then.
>
> Yeah.  I'm in process of doing that, actually.

Excellent. Are you going to look at MauMau's patch for bug #6011 also?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-05-24 18:30:52 Re: Domains versus polymorphic functions, redux
Previous Message Tom Lane 2011-05-24 18:18:28 Re: Alignment padding bytes in arrays vs the planner