From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages(). |
Date: | 2010-08-25 16:39:25 |
Message-ID: | AANLkTinudeEJcbZuXsA_t0y3OJ0R6vve9+NFbcOhsbsS@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, Aug 25, 2010 at 11:46 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Mon, 2010-08-16 at 02:02 +0000, Robert Haas wrote:
>> Log Message:
>> -----------
>> Make LockDatabaseObject() AcceptInvalidationMessages().
>>
>> This is appropriate for the same reasons we already do it in
>> LockSharedObject(): things might have changed while we were waiting
>> for the lock. There doesn't seem to be a live bug here at the moment,
>> but that's mostly because it isn't currently used for very much.
>
> I have a horrible nagging feeling this breaks something. I remember
> noticing that about a year ago and it seemed to make sense then. Sorry,
> can't recall anything else at present.
Well, the only place it's used at the moment is in the drop-object
code. Not sure if that might be enough to jog your memory?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2010-08-25 18:18:39 | pgsql: Add missing description of reloftype field |
Previous Message | Simon Riggs | 2010-08-25 15:46:16 | Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages(). |