| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SQL/MED - file_fdw |
| Date: | 2010-12-05 04:11:27 |
| Message-ID: | AANLkTinptuG1Jt=Rq6dsQ7eBTRgseoTXGzRAgd5XD-gT@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 5, 2010 at 07:24, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Looking at file_parser.c, it seems to be largely taken from copy.c. Wouldn't
> it be better to call those functions, or refactor them so they are callable
> if necessary?
We could export private functions and structs in copy.c,
though details of the implementation should be kept in copy.c.
How about splitting the file_fdw patch into two pieces?
One exports the copy functions from the core, and another
implements file_fdw using the infrastructure.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2010-12-05 05:12:19 | Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files) |
| Previous Message | Josh Berkus | 2010-12-05 03:12:57 | Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+ |