Skip site navigation (1) Skip section navigation (2)

Re: phase 2 of wxWidgets 2.9 build

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: phase 2 of wxWidgets 2.9 build
Date: 2011-02-15 23:51:47
Message-ID: AANLkTiniqzkWA0bJafQaNqBnnEa3k_oR=dbawxBY6a_F@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
I'm seeing a lot of these sorts of warnings:

In file included from ../pgadmin/include/wx/ogl/ogl.h:25:0,
                 from ./pgAdmin3.cpp:27:
../pgadmin/include/wx/ogl/basicp.h:44:31: warning: type attributes
ignored after type is already defined
../pgadmin/include/wx/ogl/basicp.h:45:31: warning: type attributes
ignored after type is already defined
../pgadmin/include/wx/ogl/basicp.h:87:23: warning: type attributes
ignored after type is already defined
../pgadmin/include/wx/ogl/basicp.h:91:32: warning: type attributes
ignored after type is already defined
In file included from ../pgadmin/include/wx/ogl/ogl.h:27:0,
                 from ./pgAdmin3.cpp:27:
../pgadmin/include/wx/ogl/linesp.h:15:23: warning: type attributes
ignored after type is already defined
../pgadmin/include/wx/ogl/linesp.h:19:32: warning: type attributes
ignored after type is already defined
mv -f .deps/pgAdmin3.Tpo .deps/pgAdmin3.Po

I'm not sure what to do, because I don't think that they should be
emitted at all, and it doesn't occur to me how they can be safely and
easily fixed. Some of those declarations are friend declarations. See
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159 for more
information. Pity that g++ doesn't have a facility for suppressing
particular warnings. I hesitate to suppress g++ warnings at a coarser
granularity than suppressing a particular troublesome warning,
particularly because these are header files.

I've fixed all other OGL related warnings, which was quite straightforward.

Attached patch will bring you up to speed. None of the extant 2.9
problems I've described appear when built against 2.8.

Apologies for the wxrc crud.

I suggest we commit this to draw a line under what I've done. The more
eyeballs on the 2.9 AUI problems and the 2.9 table editor segfaults
the better, because they are likely to be tricky to fix. I can see us
reporting more bugs to the wx guys.

-- 
Regards,
Peter Geoghegan

Attachment: patch_with_ogl.patch.gz
Description: application/x-gzip (428.9 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-02-16 12:52:24
Subject: pgAdmin III commit: Use function parameter default values as defaultsi
Previous:From: Dave PageDate: 2011-02-15 17:40:34
Subject: pgAdmin III commit: Better late than never - update the copyrightnotic

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group