Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

On Thu, Feb 17, 2011 at 2:59 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> Whoops. I had a false sense of security from ctlListView, where the
> ambiguity between which is the preferred cast from the double and long
> overloads prevents AppendItem(true) type calls from compiling at all.
> I thought that there were no such calls to Write() overloads here -
> however, there was an implicit cast to int that didn't occur with
> ctlListView, which is what caused the problem.

Yup :-)

> I would like to produce a new patch where we deal with the problem
> correctly, and create multiple, non-overloaded variants plus the
> vanilla string function that is simply called write(), ala wx
> perl/python bindings. That's probably not that hard to do, and is a
> better, safer interface for us to use, considering that these calls
> are fairly prevalent. Objections?

No objections to that, but it does need to handle interoperability
with older versions too. IOW, it needs to read/write booleans as
REG_SZ values of "true" or "false", not REG_DWORDS. There may be other
gotchas too - that's the one I was hitting though.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company