Skip site navigation (1) Skip section navigation (2)

Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pga?==?windows-1252?Q?dmin-hackers] error: expected initializer before ‘!’ tok?==?windows-1252?Q?en

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pga?==?windows-1252?Q?dmin-hackers] error: expected initializer before ‘!’ tok?==?windows-1252?Q?en
Date: 2011-03-14 20:46:43
Message-ID: AANLkTinDXgKLHt2Cb=kR1oUXHYwvzw=4VTC5yw8LopkY@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Mar 14, 2011 at 8:37 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 14 March 2011 20:22, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> So I worked a bit on this issue tonight. I think you didn't allocate
>> enough memory for filename. See the patch attached. With this patch, it
>> works OK for me. I'm wondering if the patch should also do +1 on the
>> other calloc calls. Any ideas on this?
>>
>> Can you check that it still works on Windows and Mac OS X with this patch?
>
> This would of course explain the inconsistent behaviour across
> platforms - it was undefined.
>
> This is the the classic "strlen() doesn't include null terminated byte" mistake.

Yup :-)


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgadmin-hackers by date

Next:From: Thom BrownDate: 2011-03-14 21:17:56
Subject: Re: pgAdmin III commit: Fix selection of objects in backup/restore dialogs
Previous:From: Dave PageDate: 2011-03-14 20:44:49
Subject: Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pga?==?windows-1252?Q?dmin-hackers] Re: [pgadmin-hackers] error: expected initiali?==?windows-1252?Q?zer before ‘!’ token

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group