| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Date: | 2010-05-18 03:02:27 |
| Message-ID: | AANLkTimxPtlmyIzglADRZ6Pv-spee401YrudVS8Zhuy6@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 17, 2010 at 9:01 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> (1)
>> Smart or fast shutdown requested in PM_STARTUP state always removes
>> the backup_label file if it exists. But it might be still required
>> for subsequent recovery. I changed your patch so that additionally
>> the postmaster skips deleting the backup_label in that case.
>
> Don't like the name NeedBackupLabel seems too specific. That really
> corresponds to "we were in recovery". We should have a couple of
> super-states that correspond to am in recovery/am not in recovery so we
> can drive it from that.
ISTM that we can use XLogCtl->SharedRecoveryInProgress for that.
Is this OK?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2010-05-18 03:25:09 | Re: including PID or backend ID in relpath of temp rels |
| Previous Message | Fujii Masao | 2010-05-18 02:40:20 | Re: Stefan's bug (was: max_standby_delay considered harmful) |