Re: Move WAL warning

On Thu, Feb 3, 2011 at 11:19, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Wed, Feb 2, 2011 at 18:00, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Wed, Feb 2, 2011 at 17:43, Heikki Linnakangas
>> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>>> On 02.02.2011 16:36, Magnus Hagander wrote:
>>>>
>>>> When running pg_basebackup with -x to include all transaction log, the
>>>> server will still throw a warning about xlog archiving if it's not
>>>> enabled - that is completely irrelevant since pg_basebackup has
>>>> included it already (and if it was gone, the base backup step itself
>>>> will fail - actual error and not warning).
>>>>
>>>> This patch moves the warning from do_pg_base_backup to pg_base_backup,
>>>> so it still shows when using the explicit function calls, but goes
>>>> away when using pg_basebackup.
>>>
>>> For the sake of consistency, how about moving the "pg_stop_backup complete,
>>> all required WAL segments have been archived" notice too?
>>
>> Well, it goes out as a NOTICE, so by default it doesn't show.. But
>> yeah, for code-consistency it makes sense. Like so, then.
>
> Thinking some more about it, I realized this is not going to be enough
> - we need to be able to turn off the waiting for WAL segment as well,
> in the case when you're streaming the log. Thus, it needs to be
> controllable from the backup client, and we can't just assume the
> default is ok.
>
> Attached is an updated patch that adds a NOWAIT option to BASE_BACKUP,
> that turns off the waiting. If it's set, it also doesn't warn about
> not being able to wait in the case when there is nothing to wait for,
> so this is a replacement for the previous patch.

Applied.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/