Re: Basic JSON support

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Basic JSON support
Date: 2010-09-16 14:16:10
Message-ID: AANLkTimn0OJSWjikKwAkGtoma0tGJ76DYwitnyd3-LtL@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 15, 2010 at 9:53 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> On Thu, Sep 16, 2010 at 9:44 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Did you extract this from his work, or is this completely independent?
>>  I'm a bit disinclined to say we should just toss overboard all the
>> work that's already been done.  Why did you write a new patch?
>
> I read his patch and am inspired by the work, but the code is almost
> rewritten. As my previous comment,
>  http://archives.postgresql.org/pgsql-hackers/2010-08/msg01773.php
> I think it's not a good idea to develop JSON datatype based on the
> complex node links. The point of my patch is to simplify it.
>
> I'd like to encourage use of the simplified structure to implement
> his other works, including JSONPath.

I think that if we make a habit of rewriting the contributions of
first-time contributors in toto, we will have fewer second-time
contributors. I think it would have been a good idea to discuss this
on the list before you went and did it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-09-16 14:19:53 Re: autonomous transactions
Previous Message Garick Hamlin 2010-09-16 13:59:28 Re: patch: SQL/MED(FDW) DDL