Re: pgAdmin III: the debugger does not pre-populate default values for arguments

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Nikhil S <nixmisc(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III: the debugger does not pre-populate default values for arguments
Date: 2011-02-16 12:54:31
Message-ID: AANLkTimMHrtibvTdaw_nRboXfct7UDTwK1pqgcAcXVgE@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Mon, Feb 14, 2011 at 12:53 PM, Nikhil S <nixmisc(at)gmail(dot)com> wrote:
>
>> > Ok. One way that I can think of is that since we have the typeoids
>> > handily
>> > available, we can check the same and see if it is of stringlike type
>> > (PGOID_TYPE_CHAR, PGOID_TYPE_NAME, PGOID_TYPE_TEXT, etc..). If yes, then
>> > we
>> > retain the "", else we ignore it. Sounds reasonable?
>>
>> Yes.
>>
>
> PFA, version 2 of this patch. We now check if the type of the argument is
> stringlike. If yes, we retain the "", else we default to nothing.
>
> Regards,
> Nikhils
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Thom Brown 2011-02-16 12:56:31 Re: pgAdmin III commit: Somehow forgot to commit this.
Previous Message Dave Page 2011-02-16 12:54:17 pgAdmin III commit: Somehow forgot to commit this.