| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: Isn't HANDLE 64 bits on Win64? |
| Date: | 2010-11-16 11:45:29 |
| Message-ID: | AANLkTimHE4TLo0RVQmyXwWHLYrRoN9WKv3uWGHnGHCkf@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 16, 2010 at 11:01, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Nov 16, 2010 at 01:35, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> ... and if so, isn't postmaster.c's code to transfer a HANDLE value to a
>> child process all wet?
>
> It is definitely 64-bit. sizeof(HANDLE)==8.
>
> So yes, it looks completely broken. I guess Windows doesn't actually
> *assign* you a handle larger than 2^32 until you actually ahve that
> many open handles. Typical values on my test system (win64) comes out
> at around 4000 in all tests.
Patch applied for this and backpatched to 9.0.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-11-16 13:17:32 | track_functions default |
| Previous Message | Magnus Hagander | 2010-11-16 11:39:35 | Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running |