On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> 2011/1/21 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>> The attached patch is a revised version.
>> I've committed this. Cleanup coming...
> Yikes. On further examination, exec_object_restorecon() is pretty
> bogus. Surely you need some calls to quote_literal_cstr() in there
> someplace. And how about using getObjectDescriptionOids() for the
> error message, instead of the entirely bogus construction that's there
Also, shouldn't a bunch of these messages end in ": %m"?
The Enterprise PostgreSQL Company
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2011-01-24 03:50:41|
|Subject: Re: REVIEW: WIP: plpgsql - foreach in|
|Previous:||From: Andrew Dunstan||Date: 2011-01-24 03:45:27|
|Subject: Re: Is there a way to build PostgreSQL client libraries