| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sepgsql contrib module |
| Date: | 2011-01-24 03:49:08 |
| Message-ID: | AANLkTimEcvsoEE4=+AMh97kgqmc7TQxoLFB=hzAFk4p9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> 2011/1/21 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>> The attached patch is a revised version.
>>
>> I've committed this. Cleanup coming...
>
> Yikes. On further examination, exec_object_restorecon() is pretty
> bogus. Surely you need some calls to quote_literal_cstr() in there
> someplace. And how about using getObjectDescriptionOids() for the
> error message, instead of the entirely bogus construction that's there
> now?
Also, shouldn't a bunch of these messages end in ": %m"?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-24 03:50:41 | Re: REVIEW: WIP: plpgsql - foreach in |
| Previous Message | Andrew Dunstan | 2011-01-24 03:45:27 | Re: Is there a way to build PostgreSQL client libraries with MinGW |