From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch (for 9.1) string functions |
Date: | 2010-07-12 02:58:41 |
Message-ID: | AANLkTim5xfU0iY4OcFD_JPu_zTZIeky_08oWsp3oZnmC@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jul 11, 2010 at 10:30 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> 2010/7/9 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> I am sending a actualised patch
>> * removed concat_json
>> * renamed function rvsr to reverse
>> * functions format, sprintf and concat* are stable now (as to_char for example)
>
> I'd like to move all proposed functions into the core, and not to add
> contrib/stringfunc.
> I think those functions are very useful and worth adding in core.
> * concat(), concat_ws(), reverse(), left() and right() are ready to commit.
> * format() is almost ready, except consensus of NULL representation.
> * sprintf() is also useful, but we cannot use swprintf() in it because
> there are many problems in converting to wide chars. We should
> develop mbchar-aware version of %s formatter.
> * IMHO, concat_sql() has very limited use cases. Boolean and numeric
> values are not quoted, but still need product-specific conversions because
> some DBs prefer 1/0 instead of true/false.
> Also, dblink_build_sql_insert() provides similar functionality. Will
> we have both?
I'm all in favor of putting such things in core as are supported by
multiple competing products, but is that really true for all of these?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Itagaki Takahiro | 2010-07-12 03:32:24 | Re: patch (for 9.1) string functions |
Previous Message | Itagaki Takahiro | 2010-07-12 02:30:40 | Re: patch (for 9.1) string functions |