From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: and it's not a bunny rabbit, either |
Date: | 2010-12-29 11:17:57 |
Message-ID: | AANLkTim5YTiPKZ9QVFdcbKOzezbLtkXKGZpK-zu885aJ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 29, 2010 at 4:09 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 29.12.2010 06:54, Robert Haas wrote:
>>
>> With the patch:
>>
>> rhaas=# cluster v;
>> ERROR: views do not support CLUSTER
>
> "do not support" sounds like a missing feature, rather than a nonsensical
> command. How about something like "CLUSTER cannot be used on views"
I'm fine with flipping the ordering around. I think I like it
marginally better this way, but you and Tom both seem to prefer the
opposite ordering, ergo so be it (barring a sudden influx of contrary
votes).
> The patch changes a bunch of heap_openrv() calls to relation_openrv().
> Perhaps it would be better make the error message something like "\"%s\" is
> not a table", and keep the callers unchanged. It's not particularly useful
> to repeat the command in the error message, the user should know what
> command he issued. Even if it's buried deep in a PL/pgSQL function or
> something, it should be clear from the context lines.
Did you read the whole thread?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-12-29 11:35:23 | Re: pg_streamrecv for 9.1? |
Previous Message | Magnus Hagander | 2010-12-29 10:47:53 | pg_streamrecv for 9.1? |