From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | Dan Ports <drkp(at)csail(dot)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: SSI bug? |
Date: | 2011-03-25 19:23:14 |
Message-ID: | AANLkTim-k8A0N82pZ+FL9cRFkUH-APES6ppV28Q5-0ES@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 18, 2011 at 4:51 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Dan Ports <drkp(at)csail(dot)mit(dot)edu> wrote:
>
>> I am surprised to see that error message without SSI's hint about
>> increasing max_predicate_locks_per_xact.
>
> After reviewing this, I think something along the following lines
> might be needed, for a start. I'm not sure the Asserts are actually
> needed; they basically are checking that the current behavior of
> hash_search doesn't change.
>
> I'm still looking at whether it's sane to try to issue a warning
> when an HTAB exceeds the number of entries declared as its max_size
> when it was created.
I don't see much advantage in changing these to asserts - in a debug
build, that will promote ERROR to PANIC; whereas in a production
build, they'll cause a random failure somewhere downstream.
The HASH_ENTER to HASH_ENTER_NULL changes look like they might be
needed, though.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2011-03-25 19:29:07 | Re: Pre-set Hint bits/VACUUM FREEZE on data load..? |
Previous Message | Robert Haas | 2011-03-25 19:18:41 | Re: SSI bug? |