| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Geery <andrew(dot)geery(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch |
| Date: | 2010-10-14 19:47:27 |
| Message-ID: | AANLkTikucgmzvrJru5A30Q3GJGTZ+4FLb02Fja-eqf-6@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14 October 2010 20:28, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
>> Looking in that function, there is a similar "found" variable that
>> isn't being initialised (which my compiler didn't warn about).
>> Initialising that to false, sems to fix the problem and all the
>> regression tests then pass.
>
> Excellent. Please send an updated patch.
>
OK, here it is.
I've not cured this compiler warning (in fact I'm not sure what it's
complaining about, because the variable *is* used):
tablecmds.c: In function 'ATExecSetNotNull':
tablecmds.c:4747: warning: unused variable 'is_new_constraint'
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| notnull_constraint2.patch | application/octet-stream | 57.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-10-14 19:56:05 | Re: Slow count(*) again... |
| Previous Message | Darth Revan | 2010-10-14 19:45:10 | Darth Revan wants to chat |