Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Geery <andrew(dot)geery(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch
Date: 2010-10-15 07:32:33
Message-ID: 8403693A761BDA800D46B460@amenophis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

--On 14. Oktober 2010 20:47:27 +0100 Dean Rasheed
<dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:

> OK, here it is.
>
> I've not cured this compiler warning (in fact I'm not sure what it's
> complaining about, because the variable *is* used):
>
> tablecmds.c: In function 'ATExecSetNotNull':
> tablecmds.c:4747: warning: unused variable 'is_new_constraint'

Just a left over from earlier coding, i have removed this in my patch
version. I have adapted your fixes and would like to propose that we are
proceeding with my version, if that's okay for you?

--
Thanks

Bernd

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-10-15 07:43:30 Re: column-level update privs + lock table
Previous Message Marios Vodas 2010-10-15 07:21:31 Re: knngist plans