Re: security label support, revised

On Tue, Sep 28, 2010 at 3:57 AM, Shigeru HANADA
<hanada(at)metrosystems(dot)co(dot)jp> wrote:
> On Mon, 27 Sep 2010 21:07:33 -0400
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I found and fixed a few more issues and committed this.  The pg_dump
>> support had a few escaping bugs, and I added tab completion support
>> for psql.  Considering the size of the patch, it seems likely that
>> there are some issues we both overlooked, but this is as solid as I
>> can make it for right now.
> Some OIDs used in SECURITY LABEL patch have already been used for
> some functions such as pg_stat_get_xact_numscans().
>
> The src/include/catalog/duplicate_oids script reports that 3037 ~
> 3040 are used two or more times.
>
> Though all regression tests finish successfully, should this be
> fixed ?

Woops. Thanks for the report, fixed. I wish we had a regression test
that would catch these mistakes. It's easy to forget to run this
script.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company