Re: Regression testing for psql

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Regression testing for psql
Date: 2010-05-25 03:38:25
Message-ID: AANLkTikeMaT-f2AL-t56qRbAJk97KE8KEQ-320qqornP@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 24, 2010 at 10:51 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
>>     Add regression testing for psql backslash commands
>>
>>     This patch adds rather extensive regression testing
>>     of the psql backslash commands.  Hopefully this will
>>     minimize issues such as the one which cropped up
>>     recently with \h segfaulting.  Note that we don't
>>     currently explicit check all the \h options and that
>>     pretty much any catalog changes will mean that this
>>     needs to also be updated.  Still, it's a start, we can
>>     reduce the set of tests if that makes sense or they
>>     become a problem.
>
> And..  it's way too big to send to the list.  The patch is available
> here:
>
> http://snowman.net/~sfrost/psql-regress-help.patch
>
> Of course, if people want to suggest tests that just shouldn't be
> included, I can go through and strip things out.

Well... I'm a little reluctant to believe that we should have 3.3M of
tests for the entire backend and 5M of tests just for psql. Then,
too, there's the fact that many of these tests fail on my machine
because my username is not sfrost, and/or because of row-ordering
differences on backslash commands without enough ORDER BY to fully
determine the output order.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-05-25 03:39:23 Re: (9.1) btree_gist support for searching on "not equals"
Previous Message Bruce Momjian 2010-05-25 03:35:33 Re: pg_upgrade docs