Re: Add ENCODING option to COPY

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add ENCODING option to COPY
Date: 2011-02-08 16:25:22
Message-ID: AANLkTikY4XHuxkd1g9MeaLv_yWOy0990W92q7gy6ufj+@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/2/9 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On fre, 2011-02-04 at 10:47 -0500, Tom Lane wrote:
>>> The reason that we use quotes in CREATE DATABASE is that encoding
>>> names aren't assumed to be valid SQL identifiers.  If this patch isn't
>>> following the CREATE DATABASE precedent, it's the patch that's wrong,
>>> not CREATE DATABASE.
>
>> Since encoding names are built-in and therefore well known, and the
>> names have been aligned with the SQL standard names, which are
>> identifiers, I don't think this argument is valid (anymore).
>
> What about "UTF-8"?

Then, quote it?

db1=# set client_encoding to utf-8;
ERROR: syntax error at or near "-"

Regards,

--
Hitoshi Harada

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-02-08 16:36:40 Re: Extensions support for pg_dump, patch v27
Previous Message Jeff Davis 2011-02-08 16:21:27 Re: WIP: RangeTypes