Re: RecordTransactionCommit() and SharedInvalidationMessages

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: RecordTransactionCommit() and SharedInvalidationMessages
Date: 2010-08-13 01:43:04
Message-ID: AANLkTikTgdHw+rhVN9MaNjLcAy2MyaMM7n28842L64kR@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>>> don't see a guard to prevent it from doing it in all cases.
> [...]
>>>> The fix looks pretty simple (see attached), although I don't have any
>>>> clear idea how to test it.
>>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
>> And, RelcacheInitFileInval should be initialized with false just in case.
>
> How about this?

Looks good to me.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-13 01:51:13 Re: Patch to show individual statement latencies in pgbench output
Previous Message Fujii Masao 2010-08-13 01:37:11 Re: typos in HS source code comment