Re: Parsing issue in Open pg_hba.conf dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Parsing issue in Open pg_hba.conf dialog
Date: 2011-01-14 10:51:00
Message-ID: AANLkTik-PhANr=tGyfuRahdH10KU3S-8gD_G40-aCDrc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jan 14, 2011 at 10:00 AM, Dhiraj Chawla
<dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote:
> Hi,
> Today I came across an issue in the Open pg_hba.conf dialog.
> If your pg_hba.conf is something like this:
> # "local" is for Unix domain socket connections only
> local   all             all                                     trust
> # IPv4 local connections:
> host    "all, samerole"             all             127.0.0.1/32
>  trust
> # IPv6 local connections:
> host    all             "all, agent1"             ::1/128
> trust
> Then the pg_hba.conf dialog shows something like this:
> Type          Database              User            IP-Address
>  Method          Option
> local          all                         all
>            trust
> host          "all,                       samerole"     all   127.0.0.1/32
>  trust
> host          all                         "all,              agent1"
>  ::1/128  trust
> which I guess is an issue with the parser of pg_hba.conf file.
> So I debugged it and was able to fix it.
> I am attaching the patch for the fix herewith this email.
> I am not sure if this was a correct scenario or what but this issue I was
> facing so thought of working on it.

Thanks Dhiraj - patch applied. I'm pretty surprised that didn't break
before now.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-01-15 17:46:59 pgAdmin III commit: Update german translation.
Previous Message Dave Page 2011-01-14 10:50:44 pgAdmin III commit: Fix a parser bug in the pg_hba.conf editor.