| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures |
| Date: | 2010-10-20 02:02:37 |
| Message-ID: | AANLkTi=VhagmGxL521WXsfG1sQ-KB+hnp2iB_fXG1+V=@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Restructure the pg_upgrade code to use several global structures rather
> than packing everything into 'ctx' and passing that to every function.
> -------
> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455
I see the following warning message:
----
In file included from check.c:10:
pg_upgrade.h:243: warning: built-in function ‘log’ declared as non-function
----
gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
pg_upgrade.h has a variable 'log'.
extern Log log;
It might be platform-dependent, but I think we'd better rename it.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-10-20 02:06:08 | pgsql: Further speed up pg_upgrade lookups. |
| Previous Message | Tom Lane | 2010-10-20 01:54:20 | pgsql: Update storage.sgml to describe the 9.0 tablespace directory lay |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-10-20 02:06:39 | Re: Domains versus arrays versus typmods |
| Previous Message | Robert Haas | 2010-10-20 01:37:48 | Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP) |